Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-121103: Update site module docs for free-threaded installs #122737

Merged
merged 2 commits into from
Aug 6, 2024
Merged

gh-121103: Update site module docs for free-threaded installs #122737

merged 2 commits into from
Aug 6, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Aug 6, 2024 •
edited
Loading

@colesbury colesbury added docs Documentation in the Doc dir skip news needs backport to 3.13 bugs and security fixes labels Aug 6, 2024
@colesbury colesbury requested a review from AlexWaygood August 6, 2024 15:11
@bedevere-app bedevere-app bot mentioned this pull request Aug 6, 2024
Closed
@colesbury colesbury mentioned this pull request Aug 6, 2024
Merged
AlexWaygood
AlexWaygood reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Do you also need to amend the site.USER_BASE entry?

Doc/library/site.rst Outdated Show resolved Hide resolved
Doc/library/site.rst Outdated Show resolved Hide resolved
@colesbury @AlexWaygood
Apply suggestions from code review
5a06b78 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@colesbury
Copy link
Contributor Author

I think site.USER_BASE was not changed.

@colesbury colesbury merged commit 1429651 into python:main Aug 6, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-121103-site-docs branch August 6, 2024 18:34
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2024
@colesbury @AlexWaygood @miss-islington
pythongh-121103: Update site module docs for free-threaded installs (p…
bf0902f 
…ythonGH-122737)

(cherry picked from commit 1429651)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 6, 2024

GH-122750 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 6, 2024
colesbury added a commit that referenced this pull request Aug 6, 2024
@miss-islington @colesbury @AlexWaygood
[3.13] gh-121103: Update site module docs for free-threaded installs (G…
24d15f0 
…H-122737) (#122750)

gh-121103: Update site module docs for free-threaded installs (GH-122737)
(cherry picked from commit 1429651)

Co-authored-by: Sam Gross <colesbury@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
brandtbucher pushed a commit to brandtbucher/cpython that referenced this pull request Aug 7, 2024
@colesbury @AlexWaygood @brandtbucher
pythongh-121103: Update site module docs for free-threaded installs (p…
78a30c4 
…ython#122737)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@colesbury @AlexWaygood @blhsing
pythongh-121103: Update site module docs for free-threaded installs (p…
64e891e 
…ython#122737)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @AlexWaygood